[libcxx-commits] [libcxx] [libc++] Adjust some of the [rand.dist] critical values that are too strict (PR #88669)

[Mark de Wever via libcxx-commits]

https://github.com/mordante approved this pull request.

> Is in not better to have smaller values on this?

I kind of agree, however these are statistical tests and there is no motivation why these tolerances were picked. For example 45a999719b45e1ef00d928c54ca25ef8ef6889ff

I noticed the tolerances not to work when implementing a new paper.
 
> If so, we may want to keep some testing to ensure our implementation doesn't slip? But otherwise, this change seems reasonable.

I think we could add a test where we test some specific expected values. To me this is outside the scope of this patch; unless @MattStephanson likes to do it.

I'm happy with this patch after addressing my last comment. Please give @EricWF a few days to respond before landing this patch.


https://github.com/llvm/llvm-project/pull/88669