[libcxx-commits] [libcxx] [libc++] Adjust some of the [rand.dist] critical values that are too strict (PR #88669)

Mark de Wever via libcxx-commits libcxx-commits at lists.llvm.org
Sat Apr 20 10:01:43 PDT 2024


================
@@ -151,8 +151,8 @@ void test3() {
     double x_kurtosis = (1-6*d.p()*(1-d.p())) / x_var;
     assert(std::abs((mean - x_mean) / x_mean) < 0.01);
     assert(std::abs((var - x_var) / x_var) < 0.01);
-    assert(std::abs((skew - x_skew) / x_skew) < 0.03);
-    assert(std::abs((kurtosis - x_kurtosis) / x_kurtosis) < 0.3);
----------------
mordante wrote:

Can you add something along these lines in the commit message. That give future readers more information why these changes are valid.

https://github.com/llvm/llvm-project/pull/88669


More information about the libcxx-commits mailing list