[libcxx-commits] [libcxx] [libc++][CI] Refactor creating inline files (PR #88250)

[Marius Brehler via libcxx-commits]

marbre wrote:

> > We can also drop the indention entirely as in other scripts that create files inline.
> 
> Not a fan of that either. The indentation is there for a reason. Problems with some tooling shouldn't influence how we write the code. The tooling should be fixed.

I don't have the impression that the tooling is broken and it would be an easy change to simply adjust the Dockerfile.
 
> > The scorecard action is part of the CI, thus I wouldn't necessarily agree that it works fine in the CI.
> 
> Since when? And how is it triggered? I've never seen it before, and I'm not exactly new to libc++.

The Scorecard (GitHub) action was added on Nov 1, see https://github.com/llvm/llvm-project/commit/0d3377c496ef2057224540650b657efb1848d63e. The commit that refactored the Dockerfile (https://github.com/llvm/llvm-project/commit/f4e3fb5972b2c42b5373952fccc8259e98b3423b) was actually landed after the Scorecard action was introduced.

> Your first link doesn't work. Your second link doesn't say anything about not using spaces for indentation. It just says that tabs are stripped according to the here-doc rules.

See for example https://www.oreilly.com/library/view/bash-cookbook/0596526784/ch03s04.html.

https://github.com/llvm/llvm-project/pull/88250