[libcxx-commits] [libcxx] [libc++][CI] Refactor creating inline files (PR #88250)

[Nikolas Klauser via libcxx-commits]

philnik777 wrote:

> We can also drop the indention entirely as in other scripts that create files inline.

Not a fan of that either. The indentation is there for a reason. Problems with some tooling shouldn't influence how we write the code. The tooling should be fixed.

> The scorecard action is part of the CI, thus I wouldn't necessarily agree that it works fine in the CI.

Since when? And how is it triggered? I've never seen it before, and I'm not exactly new to libc++.

> Furthermore, the Docker itself introduced here-docs as described in the 2021 blog post https://www.docker.com/blog/introduction-to-heredocs-in-dockerfiles/https://www.docker.com/blog/introduction-to-heredocs-in-dockerfiles/ and the reference https://docs.docker.com/reference/dockerfile/#example-creating-inline-files. The Dockerfile is just not following the reference.

Your first link doesn't work. Your second link doesn't say anything about not using spaces for indentation. It just says that tabs are stripped according to the here-doc rules.

https://github.com/llvm/llvm-project/pull/88250