[libcxx-commits] [PATCH] D158862: [libc++][C++20 modules] Tests no except build.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked an inline comment as done.
Mordante added inline comments.


================
Comment at: libcxx/modules/CMakeLists.txt.in:42
+if (NOT @LIBCXX_ENABLE_EXCEPTIONS@)
+  target_compile_options(std PUBLIC -fno-exceptions)
+endif()
----------------
ldionne wrote:
> Can we use a feature with `target_compile_features` here instead? That would likely solve the MSVC issue as well.
Based on https://cmake.org/cmake/help/latest/prop_gbl/CMAKE_CXX_KNOWN_FEATURES.html#prop_gbl:CMAKE_CXX_KNOWN_FEATURES there is no such feature. For now I keep it as is. What is the MSVC issue we're having? Is there a bug report?

Note the goal is to remove this file in the future and let the build system do the right thing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158862/new/

https://reviews.llvm.org/D158862