[libcxx-commits] [PATCH] D158862: [libc++][C++20 modules] Tests no except build.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM but we should take a look at `target_compile_features`.



================
Comment at: libcxx/modules/CMakeLists.txt.in:42
+if (NOT @LIBCXX_ENABLE_EXCEPTIONS@)
+  target_compile_options(std PUBLIC -fno-exceptions)
+endif()
----------------
Can we use a feature with `target_compile_features` here instead? That would likely solve the MSVC issue as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158862/new/

https://reviews.llvm.org/D158862