[libcxx-commits] [PATCH] D148432: [libc++] Simplify the tuple constructor overload set

[Jessica Clarke via Phabricator via libcxx-commits]

jrtc27 added a comment.

In D148432#4653195 <https://reviews.llvm.org/D148432#4653195>, @philnik wrote:

> In D148432#4653189 <https://reviews.llvm.org/D148432#4653189>, @jrtc27 wrote:
>
>> In D148432#4653188 <https://reviews.llvm.org/D148432#4653188>, @philnik wrote:
>>
>>> In D148432#4653185 <https://reviews.llvm.org/D148432#4653185>, @jrtc27 wrote:
>>>
>>>> To clarify: what versions of GCC and Clang are required to compile this code? Whilst we can assume GCC and Clang, if this is in code paths used for old language versions, we need to be sure compilers that are supported today for those language versions continue to be able to #include this header without issue (unlike files used solely during the build of libc++ itself, where we can more aggressively require newer compilers).
>>>
>>> libc++ currently requires at least Clang 16 or GCC 13, so we should be good on that front. We will probably add extra coverage to the CI once we enable extensions more generally.
>>
>> To build, or for anyone wishing to compile code that uses it as the standard library implementation? I would be very surprised if it's the latter. What about distributions that need to compile code with older compilers?
>
> For anyone that wants to use it. IDK about distributions that need to use old compilers, but how often do you install a custom standard library without also installing a custom compiler? Probably just about never.

libc++ isn't always a custom standard library. It's the system standard library for FreeBSD (and Android, but there's probably less concern about weird old compiler versions there). Every 6 months a new libc++ comes out, so around every 6 months (always between a bit and a lot behind) FreeBSD updates to a new version of libc++, but the freebsd-ports collection is *huge* and has many old compiler versions, both GCC and Clang, available and used. We try to avoid them where possible, but sometimes it's what has to happen. GCC in particular; code that compiles with Clang tends to be more modern and less picky about compilers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148432/new/

https://reviews.llvm.org/D148432