[libcxx-commits] [PATCH] D148432: [libc++] Simplify the tuple constructor overload set

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D148432#4653189 <https://reviews.llvm.org/D148432#4653189>, @jrtc27 wrote:

> In D148432#4653188 <https://reviews.llvm.org/D148432#4653188>, @philnik wrote:
>
>> In D148432#4653185 <https://reviews.llvm.org/D148432#4653185>, @jrtc27 wrote:
>>
>>> To clarify: what versions of GCC and Clang are required to compile this code? Whilst we can assume GCC and Clang, if this is in code paths used for old language versions, we need to be sure compilers that are supported today for those language versions continue to be able to #include this header without issue (unlike files used solely during the build of libc++ itself, where we can more aggressively require newer compilers).
>>
>> libc++ currently requires at least Clang 16 or GCC 13, so we should be good on that front. We will probably add extra coverage to the CI once we enable extensions more generally.
>
> To build, or for anyone wishing to compile code that uses it as the standard library implementation? I would be very surprised if it's the latter. What about distributions that need to compile code with older compilers?

For anyone that wants to use it. IDK about distributions that need to use old compilers, but how often do you install a custom standard library without also installing a custom compiler? Probably just about never.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148432/new/

https://reviews.llvm.org/D148432