[libcxx-commits] [libcxx] [libc++][test] `ADDITIONAL_COMPILE_FLAGS` should be a comma-separated list (PR #73541)

Mark de Wever via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 27 09:24:38 PST 2023


mordante wrote:

> > TIL! Thanks for fixing these! I found 4 more in test/std, they all seem to be -Xclang -verify-ignore-unexpected=error. There are several more in libcxx. Feel free to fix these too, or leave a message, then I'll create a followup PR.
> 
> You're welcome! If you could create a followup PR that would be great

No problem, I'll do it after this patch has landed.

> - I'm not equipped to properly test changes to the `-Xclang` options or anything in `libcxx/test/libcxx`.

That's why we have a CI ;-)

https://github.com/llvm/llvm-project/pull/73541


More information about the libcxx-commits mailing list