[libcxx-commits] [libcxx] [libc++][test] `ADDITIONAL_COMPILE_FLAGS` should be a comma-separated list (PR #73541)

[Stephan T. Lavavej via libcxx-commits]

StephanTLavavej wrote:

@philnik777
> I think we should rather go the other way around and make the flag space-separated. Having it comma separated seems like a poor UI design to me, since every compiler I'm aware of assumes a space-separated list of arguments.

Space-separated seems like a good idea to me too - I didn't try that because it would be a large change to the test harness, and would involve changing a small amount of existing usage that's already using commas.

@mordante
> TIL! Thanks for fixing these! I found 4 more in test/std, they all seem to be -Xclang -verify-ignore-unexpected=error. There are several more in libcxx. Feel free to fix these too, or leave a message, then I'll create a followup PR.

You're welcome! If you could create a followup PR that would be great - I'm not equipped to properly test changes to the `-Xclang` options or anything in `libcxx/test/libcxx`.

https://github.com/llvm/llvm-project/pull/73541