[libcxx-commits] [libcxx] Adds back special-case for booleans in std::variant gated by _LIBCPP_ENABLE_NARROWING_CONVERSIONS_IN_VARIANT. (PR #73121)

[Zhihao Yuan via libcxx-commits]

lichray wrote:

> 3. http://wg21.link/p1957 actually explores the impact on some large code bases like Google's code base. It says it found 2 issues, which seems to be incorrect. @zhihaoy can you provide more context since you authored the paper?

The paper explored the impact of the language change. At that time pre- 170810f libc++ is not being used. The breakage seems to be caused by later added code that counts on the pre- 170810f behavior which doesn't belong to any standard, nor is shared by other implementations. As @bgra8 says, those codes would be clearly wrong, but Google may need time to figure out.


https://github.com/llvm/llvm-project/pull/73121