[libcxx-commits] [libcxx] Adds back special-case for booleans in std::variant gated by _LIBCPP_ENABLE_NARROWING_CONVERSIONS_IN_VARIANT. (PR #73121)
Louis Dionne via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Nov 22 08:24:28 PST 2023
ldionne wrote:
> > Can you share some examples of compilation errors you're seeing after this change? Are they vexing or are they stuff where the code was clearly wrong in the first place?
>
> Most of the breakages are caused by clearly wrong code in the first place: https://godbolt.org/z/j6Tj864jT
I am a bit confused by this Godbolt -- it seems like that code wasn't accepted by Clang 16 either, so this is probably not related to this change. https://godbolt.org/z/xjYj1eccq
>
> > Same for runtime errors -- this is actually way more worrisome.
>
> We are actively working for reproducers here. Are you OK if we post them later?
Like I said, we need to understand the situation before we can make a decision about how to handle this. There's no desire to delay this more than needed, but at the moment we have no information. If this patch needs to land within minutes in order to unblock you downstream, that's fair but in that case you should apply it downstream first while we work out what to do upstream, which may take a bit more than just a few minutes.
https://github.com/llvm/llvm-project/pull/73121
More information about the libcxx-commits
mailing list