[libcxx-commits] [libcxx] [libc++] Stop checking for trailing whitespace in check-generated-output (PR #72711)
via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Nov 17 14:16:15 PST 2023
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libcxx
Author: Louis Dionne (ldionne)
<details>
<summary>Changes</summary>
Trailing whitespace is removed by clang-format, so if someone tries to check-in new code with trailing whitespaces, it'll be caught by the clang-format job. Removing this duplication helps reduce the confusion around our numerous ways of enforcing formatting rules.
---
Full diff: https://github.com/llvm/llvm-project/pull/72711.diff
1 Files Affected:
- (modified) libcxx/utils/ci/run-buildbot (-3)
``````````diff
diff --git a/libcxx/utils/ci/run-buildbot b/libcxx/utils/ci/run-buildbot
index fe99388a799be8a..65d0cd6ee6b2871 100755
--- a/libcxx/utils/ci/run-buildbot
+++ b/libcxx/utils/ci/run-buildbot
@@ -262,9 +262,6 @@ check-generated-output)
--exclude 'transcoding.pass.cpp' \
--exclude 'underflow.pass.cpp' \
|| false
-
- # Reject code with trailing whitespace
- ! grep -rn '[[:blank:]]$' libcxx/include libcxx/src libcxx/test libcxx/benchmarks || false
;;
#
# Various Standard modes
``````````
</details>
https://github.com/llvm/llvm-project/pull/72711
More information about the libcxx-commits
mailing list