[libcxx-commits] [libcxx] [libc++] Stop checking for trailing whitespace in check-generated-output (PR #72711)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Fri Nov 17 14:15:48 PST 2023


https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/72711

Trailing whitespace is removed by clang-format, so if someone tries to check-in new code with trailing whitespaces, it'll be caught by the clang-format job. Removing this duplication helps reduce the confusion around our numerous ways of enforcing formatting rules.

>From f6f70fc9080fa10436d77c399e1cc5544c168ebe Mon Sep 17 00:00:00 2001
From: Louis Dionne <ldionne.2 at gmail.com>
Date: Fri, 17 Nov 2023 17:14:20 -0500
Subject: [PATCH] [libc++] Stop checking for trailing whitespace in
 check-generated-output

Trailing whitespace is removed by clang-format, so if someone tries to
check-in new code with trailing whitespaces, it'll be caught by the
clang-format job. Removing this duplication helps reduce the confusion
around our numerous ways of enforcing formatting rules.
---
 libcxx/utils/ci/run-buildbot | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/libcxx/utils/ci/run-buildbot b/libcxx/utils/ci/run-buildbot
index fe99388a799be8a..65d0cd6ee6b2871 100755
--- a/libcxx/utils/ci/run-buildbot
+++ b/libcxx/utils/ci/run-buildbot
@@ -262,9 +262,6 @@ check-generated-output)
            --exclude 'transcoding.pass.cpp' \
            --exclude 'underflow.pass.cpp' \
            || false
-
-    # Reject code with trailing whitespace
-    ! grep -rn '[[:blank:]]$' libcxx/include libcxx/src libcxx/test libcxx/benchmarks || false
 ;;
 #
 # Various Standard modes



More information about the libcxx-commits mailing list