[libcxx-commits] [PATCH] D154246: [libc++] Add check for building with picolibc

[Alexander Richardson via Phabricator via libcxx-commits]

arichardson added a comment.

Not quite sure what is going on with the CI here, it sounds like GCC is happy with those tests even though the has-64-bit-atomics feature check fails. Should be good to land once that has been fixed and once @ldionne has approved this review.



================
Comment at: libcxx/test/libcxx/selftest/dsl/dsl.sh.py:10
+# Picolibc test executor is `true` at present.
+# XFAIL: LIBCXX-PICOLIBC-FIXME
+
----------------
To be pedantic, this is not really a problem with picolibc but rather with using an executor stub. Maybe XFAIL: libcxx-fake-executor and defining that feature in the .cfg?


================
Comment at: libcxx/test/libcxx/selftest/pass.cpp/run-error.pass.cpp:9
 
+// UNSUPPORTED: LIBCXX-PICOLIBC-FIXME
 // XFAIL: *
----------------
Same here 


================
Comment at: libcxx/test/libcxx/selftest/pass.mm/run-error.pass.mm:10
 // REQUIRES: objective-c++
+// UNSUPPORTED: LIBCXX-PICOLIBC-FIXME
 
----------------
And here 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154246/new/

https://reviews.llvm.org/D154246