[libcxx-commits] [PATCH] D154246: [libc++] Add check for building with picolibc

[Dominik Wójt via Phabricator via libcxx-commits]

domin144 marked 3 inline comments as done.
domin144 added inline comments.


================
Comment at: libcxx/test/libcxx/system_reserved_names.gen.py:105
+// picolibc uses __input as a parameter name of a64l & l64a
+#ifndef _NEWLIB_VERSION
+# define __input SYSTEM_RESERVED_NAME
----------------
arichardson wrote:
> michaelplatings wrote:
> > ldionne wrote:
> > > What is the relationship between picolibc and `_NEWLIB_VERSION`?
> > Picolibc is derived from Newlib, so defines _NEWLIB_VERSION. I've updated the comment to make it clear that it applies to both libraries.
> So it seems this header needs the picolibc.h include? Could we just add something like #include <stdlib.h> to the top of this file?
Done.


================
Comment at: libcxxabi/test/configs/armv7m-libc++abi.cfg.in:29
+# using this feature.
+config.available_features.add('LIBCXX-PICOLIBC-FIXME')
+
----------------
arichardson wrote:
> I believe this is not needed anymore since it's in features.oy now?
Good spot, I removed this part in the libc++ version and missed it here. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154246/new/

https://reviews.llvm.org/D154246