[libcxx-commits] [PATCH] D151830: [libc++] Refactor the mandatory header inclusion tests to .gen.py

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/typeinfo:11
+#ifndef _LIBCPP_TYPEINFO
+#define _LIBCPP_TYPEINFO
 
----------------
Please land this as a separate NFC commit.


================
Comment at: libcxx/test/libcxx/header_inclusions.gen.py:12
+
+# RUN: %{python} %s %{libcxx}/utils
+
----------------
Not really related to this patch, but could a followup also validate `__assert` is included?


================
Comment at: libcxx/utils/generate_header_inclusion_tests.py:98
-lit_markup = {
-    "barrier": ["UNSUPPORTED: no-threads"],
-    "filesystem": ["UNSUPPORTED: no-filesystem"],
----------------
ldionne wrote:
> This way of enabling/disabling the tests is better than `#ifdef`. In this patch, the new tests are using `#ifdef` to be consistent with other `.gen.py` tests, but a future patch I have locally will transition everything to `UNSUPPORTED` markup instead.
Would it be possible to post these as stacked commits? That makes it easier to determine how happy I am with this patch. I feel we loose some nice features, but when I see how they will return I probably feel better about the temporary loss.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151830/new/

https://reviews.llvm.org/D151830