[libcxx-commits] [PATCH] D151830: [libc++] Refactor the mandatory header inclusion tests to .gen.py

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed May 31 12:39:17 PDT 2023


ldionne added inline comments.


================
Comment at: libcxx/utils/generate_header_inclusion_tests.py:98
-lit_markup = {
-    "barrier": ["UNSUPPORTED: no-threads"],
-    "filesystem": ["UNSUPPORTED: no-filesystem"],
----------------
This way of enabling/disabling the tests is better than `#ifdef`. In this patch, the new tests are using `#ifdef` to be consistent with other `.gen.py` tests, but a future patch I have locally will transition everything to `UNSUPPORTED` markup instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151830/new/

https://reviews.llvm.org/D151830



More information about the libcxx-commits mailing list