[libcxx-commits] [PATCH] D151474: [libc++] Deprecate the classes in strstream.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Thanks for the reviews. I'll add release notes before committing.



================
Comment at: libcxx/include/strstream:144
 
-class _LIBCPP_TYPE_VIS strstreambuf
+class _LIBCPP_DEPRECATED_IN_CXX11 _LIBCPP_TYPE_VIS strstreambuf
     : public streambuf
----------------
philnik wrote:
> Mordante wrote:
> > philnik wrote:
> > > At least according to cppreference, these have been deprecated since C++98, so we should just use `_LIBCPP_DEPRECATED`.
> > Hmm indeed. I noticed in the draft repo they were deprecated in C++11. I never bothered to look before that time.
> > TIL things were standardized as deprecated :-/
> That's the bad part about the "standardizing existing practice". It would also have been better to not standardize implicit `return 0;` in `main`, but that happened too.
At least that part is backwards compatibility with C. It's mainly that I'm surprised that the first version of the ISO Standard already deprecates things.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151474/new/

https://reviews.llvm.org/D151474