[libcxx-commits] [PATCH] D151474: [libc++] Deprecate the classes in strstream.

Mon May 29 14:40:00 PDT 2023

philnik accepted this revision.
philnik added a comment.

+1 for a release note.

================
Comment at: libcxx/include/strstream:144

-class _LIBCPP_TYPE_VIS strstreambuf
+class _LIBCPP_DEPRECATED_IN_CXX11 _LIBCPP_TYPE_VIS strstreambuf
     : public streambuf
----------------
Mordante wrote:
> philnik wrote:
> > At least according to cppreference, these have been deprecated since C++98, so we should just use `_LIBCPP_DEPRECATED`.
> Hmm indeed. I noticed in the draft repo they were deprecated in C++11. I never bothered to look before that time.
> TIL things were standardized as deprecated :-/
That's the bad part about the "standardizing existing practice". It would also have been better to not standardize implicit `return 0;` in `main`, but that happened too.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151474/new/

https://reviews.llvm.org/D151474