[libcxx-commits] [PATCH] D151654: [libc++] Transition all remaining generated tests to the new .gen format

[Louis Dionne via Phabricator via libcxx-commits]

ldionne marked an inline comment as done.
ldionne added inline comments.


================
Comment at: libcxx/test/libcxx/clang_tidy.gen.py:18
+for header in public_headers:
+  BLOCKLIT = '' # block Lit from interpreting a RUN/XFAIL/etc inside the generation script
+  test_condition_begin = '#if ' + header_restrictions[header] if header in header_restrictions else ''
----------------
philnik wrote:
> Given that we will most likely need this in (almost) every gen test, maybe we want to just make this a utility variable for gen tests? IDK whether we want to add a few utility functions/variables like this, but will definitely need at least some variables anyways.
I think this will eventually transition for  `XFAIL` instead of `#ifdef` in the future now that we have one test per header, so I would wait until we make that change to see whether that's worth refactoring.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151654/new/

https://reviews.llvm.org/D151654