[libcxx-commits] [PATCH] D151654: [libc++] Transition all remaining generated tests to the new .gen format

Nikolas Klauser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon May 29 14:32:01 PDT 2023


philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

LGTM with green CI.



================
Comment at: libcxx/test/libcxx/clang_tidy.gen.py:18
+for header in public_headers:
+  BLOCKLIT = '' # block Lit from interpreting a RUN/XFAIL/etc inside the generation script
+  test_condition_begin = '#if ' + header_restrictions[header] if header in header_restrictions else ''
----------------
Given that we will most likely need this in (almost) every gen test, maybe we want to just make this a utility variable for gen tests? IDK whether we want to add a few utility functions/variables like this, but will definitely need at least some variables anyways.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151654/new/

https://reviews.llvm.org/D151654



More information about the libcxx-commits mailing list