[libcxx-commits] [PATCH] D150813: [libc++][docs] Add note about RFCs for significant changes

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/docs/Contributing.rst:31
+
+Before you start working on a significant change or a change that can have significant impact on users
+of the library, please consider creating a RFC on `libc++'s Discourse forum <https://discourse.llvm.org/c/runtimes/libcxx>`__.
----------------
philnik wrote:
> I think just saying "that might have a significant impact on the user" is enough. I don't see the point of making an RFC for changes that are purely project-internal. We should just discuss this kind of stuff on the monthly meetup once we have that set up. If there are concerns about user interactions we can still write an RFC. (e.g. I don't think there is a point in asking whether we can rename `_LIBCPP_CONSTEXPR_AFTER_CXXab` to `_LIBCPP_CONSTEXPR_SINCE_CXXcd`)
@Mordante Are you fine with that? I am, but IIUC one of your concerns was that we often didn't do a RFC on Discourse for project-internal discussions as well, which could sometimes lead to a consensus that isn't clear to everyone.

I'd be fine with keeping the wording as-is or to changing it to only include decisions that potentially have significant impact on users.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150813/new/

https://reviews.llvm.org/D150813