[libcxx-commits] [PATCH] D150813: [libc++][docs] Add note about RFCs for significant changes

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

LGTM % nit.



================
Comment at: libcxx/docs/Contributing.rst:31
+
+Before you start working on a significant change or a change that can have significant impact on users
+of the library, please consider creating a RFC on `libc++'s Discourse forum <https://discourse.llvm.org/c/runtimes/libcxx>`__.
----------------
I think just saying "that might have a significant impact on the user" is enough. I don't see the point of making an RFC for changes that are purely project-internal. We should just discuss this kind of stuff on the monthly meetup once we have that set up. If there are concerns about user interactions we can still write an RFC. (e.g. I don't think there is a point in asking whether we can rename `_LIBCPP_CONSTEXPR_AFTER_CXXab` to `_LIBCPP_CONSTEXPR_SINCE_CXXcd`)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150813/new/

https://reviews.llvm.org/D150813