[libcxx-commits] [PATCH] D151224: [libc++] Fixes clang-tidy plugin for clang-tidy 17.

Wed May 24 08:39:17 PDT 2023

philnik accepted this revision.
philnik added a comment.
This revision is now accepted and ready to land.

In D151224#4368627 <https://reviews.llvm.org/D151224#4368627>, @Mordante wrote:

> In D151224#4365477 <https://reviews.llvm.org/D151224#4365477>, @philnik wrote:
>
>> Are you sure this is expected? I can't really imagine a scenario where an attribute doesn't have a name. Clang itself also seems to assume that the pointer is non-null, since it just dereferences it instantly in quite a few places.
>
> I know the CI with clang-tidy 17 crashes, due to it. After this change it passed. Note the original code has a similar test at one place. I haven't checked what Clang does.

Hmm. I guess it's fine since there was a check already.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151224/new/

https://reviews.llvm.org/D151224