[libcxx-commits] [PATCH] D151224: [libc++] Fixes clang-tidy plugin for clang-tidy 17.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D151224#4365477 <https://reviews.llvm.org/D151224#4365477>, @philnik wrote:

> Are you sure this is expected? I can't really imagine a scenario where an attribute doesn't have a name. Clang itself also seems to assume that the pointer is non-null, since it just dereferences it instantly in quite a few places.

I know the CI with clang-tidy 17 crashes, due to it. After this change it passed. Note the original code has a similar test at one place. I haven't checked what Clang does.



================
Comment at: libcxx/test/tools/clang_tidy_checks/uglify_attributes.cpp:83
       return true;
-  if (Node.getAttrName())
-    return !isUgly(Node.getAttrName()->getName());
----------------
@philnik here the original code has a test too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151224/new/

https://reviews.llvm.org/D151224