[libcxx-commits] [PATCH] D151156: [WIP][libc++] Support on-the-fly generated tests

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

Thanks a lot for working on this! I really think this is very useful. Just a few nits, but I would like to see it after a green CI run.



================
Comment at: libcxx/test/libcxx/lit.local.cfg:5
+
+# Several tests in this directory require additional information about libc++ headers
+# to generate tests.
----------------
philnik wrote:
> ldionne wrote:
> > This stuff would have to be duplicated until all the tests are moved to this new format.
> Could we move this to its own file? `lit.local.cfg` isn't exactly the first place I'd expect some data. Maybe just put something like `header_test_info.py` into `libcxx/utils/data`?
+1


================
Comment at: libcxx/test/libcxx/lit.local.cfg:20
+
+    # TODO LLVM17: simplify this to __cplusplus >= 202002L
+    "coroutine": "(defined(__cpp_impl_coroutine) && __cpp_impl_coroutine >= 201902L) || (defined(__cpp_coroutines) && __cpp_coroutines >= 201703L)",
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151156/new/

https://reviews.llvm.org/D151156