[libcxx-commits] [PATCH] D151156: [WIP][libc++] Support on-the-fly generated tests

[Aaron Ballman via Phabricator via libcxx-commits]

aaron.ballman added a comment.

In D151156#4362994 <https://reviews.llvm.org/D151156#4362994>, @ldionne wrote:

> In D151156#4362491 <https://reviews.llvm.org/D151156#4362491>, @aaron.ballman wrote:
>
>> What's the expectation for folks on Windows (where .sh isn't likely to work too well)?
>
> I believe we're using Lit's internal shell which actually also works on Windows. In this case, the invocation is extremely simple -- we basically call `python <script>` so that should work on windows just as well. There really isn't much of a change compared to how we used to do things, but this shifts the moment at which the generation happens (from being explicit via developer running a command to being implicit when you run the test suite).

Ah, thank you! I hadn't realized this was using lit's internal shell, I thought these scripts were to be executed on the command line as well. If it's all going through python and lit, that sounds lovely to me. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151156/new/

https://reviews.llvm.org/D151156