[libcxx-commits] [PATCH] D144742: [libc++][format] Improves fill character.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked an inline comment as done.
Mordante added a comment.

Thanks for the review!



================
Comment at: libcxx/include/__format/parser_std_format_spec.h:452
+    if (__consumed.__status != __unicode::__consume_result::__ok)
+      std::__throw_format_error("The format-spec contains malformed Unicode");
+
----------------
tahonermann wrote:
> "... contains an ill-formed code unit sequence" seems more accurate to me, but that is probably too technical for the intended audience.
> "... contains an ill-formed code unit sequence" seems more accurate to me, but that is probably too technical for the intended audience.

Yes, I tried to keep the target audience in mind when I wrote the message. If it was purely internally I would have picked a more accurate message.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144742/new/

https://reviews.llvm.org/D144742