[libcxx-commits] [PATCH] D144742: [libc++][format] Improves fill character.

[Tom Honermann via Phabricator via libcxx-commits]

tahonermann accepted this revision.
tahonermann added a comment.

This looks good to me now. I added one comment with suggested alternatives for the new error message, but your call on whether you like them better then what you have.



================
Comment at: libcxx/include/__format/parser_std_format_spec.h:452
+    if (__consumed.__status != __unicode::__consume_result::__ok)
+      std::__throw_format_error("The format-spec contains malformed Unicode");
+
----------------
"... contains an ill-formed code unit sequence" seems more accurate to me, but that is probably too technical for the intended audience.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144742/new/

https://reviews.llvm.org/D144742