[libcxx-commits] [PATCH] D150060: [libc++][format] Removes optional dependency.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante abandoned this revision.
Mordante added a comment.

In D150060#4347359 <https://reviews.llvm.org/D150060#4347359>, @EricWF wrote:

> I'm with ldionne that we should keep using optional here. The correctness seems like a very important quality that we'll be loosing some certainty in.

My main concern was when we need a `formatter<optional, charT>`. In D150509 <https://reviews.llvm.org/D150509> I tested an alternative approach as suggested by Louis, which works without creating header cycles. So when somebody writes a paper for such a formatter we don't risk possible ABI breaks.

(MSVC STL and libstdc++ don't use an optional to implement the locale.)

Since the alternative works, this patch will be abandoned.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150060/new/

https://reviews.llvm.org/D150060