[libcxx-commits] [PATCH] D150060: [libc++][format] Removes optional dependency.

Eric Fiselier via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue May 16 12:18:48 PDT 2023


EricWF added a comment.

I'm with ldionne that we should keep using optional here. The correctness seems like a very important quality that we'll be loosing some certainty in.



================
Comment at: libcxx/include/__format/format_context.h:56
+// std::locale() is done once and only when needed.
+class __locale {
+public:
----------------
I think `__locale` is already a class inside namespace `std`. I would prefer that we use a slightly different name so it's more clear when the type is spelled elsewhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150060/new/

https://reviews.llvm.org/D150060



More information about the libcxx-commits mailing list