[libcxx-commits] [PATCH] D150695: [libc++] Install GCC 13 in the docker containers

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue May 16 12:08:12 PDT 2023


ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

In D150695#4347160 <https://reviews.llvm.org/D150695#4347160>, @Mordante wrote:

> I don't feel strongly about using jammy+ppa versus lunar, maybe @ldionne does, so I leave the final approval to him.

I don't have a preference either, as long as we're running on a stable version of Ubuntu. This is a stable version, right? We don't need LTS or anything, we just don't want something unstable (equivalent of ToT or whatever).

This LGTM but indeed it would be nice to test this before landing:

1. Build the image
2. Run one or two CI configurations just to make sure it works. Maybe the sanitizers since they sometimes seem more reliant on the OS?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150695/new/

https://reviews.llvm.org/D150695



More information about the libcxx-commits mailing list