[libcxx-commits] [PATCH] D150695: [libc++] Install GCC 13 in the docker containers

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue May 16 11:20:22 PDT 2023


Mordante accepted this revision as: Mordante.
Mordante added a comment.

Thanks for working on this. I was waiting for GCC-13 to be available in ppa to make this change.
It seems it's there for 3 days https://launchpad.net/~ubuntu-toolchain-r/+archive/ubuntu/test

(As a side note I wanted to update the Clang version in the CI to take advantage of `-std=c++26` (landed yesterday), instead I wait for you to do that with this patch.)

I don't feel strongly about using jammy+ppa versus lunar, maybe @ldionne does, so I leave the final approval to him.



================
Comment at: libcxx/utils/ci/Dockerfile:33
 
-FROM ubuntu:jammy
+FROM ubuntu:lunar
 
----------------
This change may break things, updating to Jammy had some issues. Can you make sure this works with our CI before committing?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150695/new/

https://reviews.llvm.org/D150695



More information about the libcxx-commits mailing list