[libcxx-commits] [PATCH] D149351: [libc++] Moves unwrap_reference to type_traits.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat May 13 02:34:35 PDT 2023


Mordante marked 4 inline comments as done.
Mordante added a comment.

Thanks for the review!



================
Comment at: libcxx/include/module.modulemap.in:951-952
     header "functional"
+    // the contents of __type_traits/unwrap_ref.h should be available from functional too.
+    export type_traits
     export *
----------------
philnik wrote:
> IMO we should only export the actually required parts, not all of `type_traits`.
That indeed seems to work too, in the past this didn't always work, not sure why.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149351/new/

https://reviews.llvm.org/D149351



More information about the libcxx-commits mailing list