[libcxx-commits] [PATCH] D149351: [libc++] Moves unwrap_reference to type_traits.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added inline comments.


================
Comment at: libcxx/include/__type_traits/unwrap_ref.h:45
 using unwrap_ref_decay_t = typename unwrap_ref_decay<_Tp>::type;
-#endif // > C++17
+#endif // >= C++20
 
----------------
Maybe make this `_LIBCPP_STD_VER >= 20` while you're at it?


================
Comment at: libcxx/include/module.modulemap.in:951-952
     header "functional"
+    // the contents of __type_traits/unwrap_ref.h should be available from functional too.
+    export type_traits
     export *
----------------
IMO we should only export the actually required parts, not all of `type_traits`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149351/new/

https://reviews.llvm.org/D149351