[libcxx-commits] [PATCH] D150041: [NFC][libc++][format] Tests formatter requirements.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante marked 4 inline comments as done.
Mordante added a comment.

In D150041#4329887 <https://reviews.llvm.org/D150041#4329887>, @ldionne wrote:

> LGTM w/ comments and CI.

The CI was green, updating the result on Phab was red. I've applied the fixes to the earlier committed `vector<bool>::reference` too.



================
Comment at: libcxx/test/std/containers/container.adaptors/container.adaptors.format/types.compile.pass.cpp:27-30
+// Tests parts of the BasicFormatter requirements. Like the formattable concept
+// it uses the semiregular concept. It test does not use the formattable
+// concept since it is the intention the formatter is available without
+// including the format header.
----------------
ldionne wrote:
> I think this comment does not apply to this test.
I've changed the wording slightly why we don't use the concept here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150041/new/

https://reviews.llvm.org/D150041