[libcxx-commits] [PATCH] D150041: [NFC][libc++][format] Tests formatter requirements.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM w/ comments and CI.



================
Comment at: libcxx/test/std/containers/container.adaptors/container.adaptors.format/types.compile.pass.cpp:19
+// Note it is unspecified in which header the adaptor formatters reside. In
+// lib++ they are in <format>. However their own headers are still required for
+// the declarations of these types.
----------------



================
Comment at: libcxx/test/std/containers/container.adaptors/container.adaptors.format/types.compile.pass.cpp:27-30
+// Tests parts of the BasicFormatter requirements. Like the formattable concept
+// it uses the semiregular concept. It test does not use the formattable
+// concept since it is the intention the formatter is available without
+// including the format header.
----------------
I think this comment does not apply to this test.


================
Comment at: libcxx/test/std/thread/thread.threads/thread.thread.class/thread.thread.id/types.compile.pass.cpp:21-24
+// Tests parts of the BasicFormatter requirements. Like the formattable concept
+// it uses the semiregular concept. It test does not use the formattable
+// concept since it is the intention the formatter is available without
+// including the format header.
----------------



================
Comment at: libcxx/test/std/utilities/format/types.compile.pass.cpp:55-58
+// Tests parts of the BasicFormatter requirements. Like the formattable concept
+// it uses the semiregular concept. It test does not use the formattable
+// concept since it is the intention the formatter is available without
+// including the format header.
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150041/new/

https://reviews.llvm.org/D150041