[libcxx-commits] [PATCH] D149092: [libcxxabi] disable lib{std}c++ assertions

[Nick Desaulniers via Phabricator via libcxx-commits]

nickdesaulniers added a comment.

In D149092#4316236 <https://reviews.llvm.org/D149092#4316236>, @philnik wrote:

> In D149092#4316184 <https://reviews.llvm.org/D149092#4316184>, @nickdesaulniers wrote:
>
>> Hot take; this patch is NFC for libc++. IF any code from libc++ being used in libcxxabi could assert, libcxxabi would have failed to build with a linkage failure against `__libcpp_verbose_abort` since libc++ asserts call `__libcpp_verbose_abort` upon assertion failure.
>>
>> Also, this patch isn't something small/for fun, it's blocking keeping libcxxabi's demangler in sync with LLVM's, so it's not something that we can ignore.
>
> Even if it is NFC, it's still surprising.

Surprising that I'm explicitly disabling asserts that we weren't using in the first place? (If we were using them, how were we able to link libc++abi.so without a definition of `__libcpp_verbose_abort`?)

> Switching to `string_view` is in this case a functional change, so we should consider what we want to do here.

Then that should be debated in the patch that's doing that (D148566 <https://reviews.llvm.org/D148566>) which has already been approved.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149092/new/

https://reviews.llvm.org/D149092