[libcxx-commits] [PATCH] D149092: [libcxxabi] disable lib{std}c++ assertions

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik added a comment.

In D149092#4316184 <https://reviews.llvm.org/D149092#4316184>, @nickdesaulniers wrote:

> Hot take; this patch is NFC for libc++. IF any code from libc++ being used in libcxxabi could assert, libcxxabi would have failed to build with a linkage failure against `__libcpp_verbose_abort` since libc++ asserts call `__libcpp_verbose_abort` upon assertion failure.
>
> Also, this patch isn't something small/for fun, it's blocking keeping libcxxabi's demangler in sync with LLVM's, so it's not something that we can ignore.

Even if it is NFC, it's still surprising. Switching to `string_view` is in this case a functional change, so we should consider what we want to do here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149092/new/

https://reviews.llvm.org/D149092