[libcxx-commits] [PATCH] D141882: [libc++] Remove #pragma GCC system_header

[Hans Wennborg via Phabricator via libcxx-commits]

hans added a comment.

In D141882#4233721 <https://reviews.llvm.org/D141882#4233721>, @ldionne wrote:

> I'll take this for a spin internally to see how much breakage this causes. Can you do the same with Chromium to try and quantify how much pain this causes?

For Chromium, we're fine except for Windows. As I mentioned above, we ran into trouble when we tried to switch to clang-cl's equivalent of `-isystem` because it affects the include path search order, which needs to be exactly right to make libc++ and msvc's headers work together.

We could probably figure it out with some more work (it's hard to say how much, I think I spent 1-2 days on it last time without succeeding), but I worry that others might run into similar problems.

> It would sure be nice to shake the tree a bit and "encourage" users that include libc++ incorrectly to do it properly, while staying within the realm of what's reasonable of course.

It seems like this has potential for a lot of breakage with not much benefit, but that's just my two cents.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141882/new/

https://reviews.llvm.org/D141882