[libcxx-commits] [PATCH] D141882: [libc++] Remove #pragma GCC system_header

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D141882#4219443 <https://reviews.llvm.org/D141882#4219443>, @hans wrote:

> These pragmas have been in libc++'s header since the initial import. Does anyone know what was the original motivation, and whether or not it still applies?

I do not know the original motivation, but I imagine it might have been to work around users incorrectly using `-I` to include headers, or maybe even for Howard himself when he first bootstrapped the library. I don't know for sure though.

I'll take this for a spin internally to see how much breakage this causes. Can you do the same with Chromium to try and quantify how much pain this causes?

It would sure be nice to shake the tree a bit and "encourage" users that include libc++ incorrectly to do it properly, while staying within the realm of what's reasonable of course.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141882/new/

https://reviews.llvm.org/D141882