[libcxx-commits] [PATCH] D146991: [libc++][NFC] Rename helper function for testing spaceship

Tue Mar 28 06:58:29 PDT 2023

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

In D146991#4226534 <https://reviews.llvm.org/D146991#4226534>, @H-G-Hristov wrote:

> @ldionne Thank you for pointing this out and fixing it. LGTM
>
> Some of the tests are also misplaced and I have a patch to correct that https://reviews.llvm.org/D146902. I suppose I need to wait for you to commit these changes, so I can rebase and commit my fix to avoid conflicts.

Ok, let's do that! I wasn't aware of D146902 <https://reviews.llvm.org/D146902>, otherwise I would have held off with this change.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146991/new/

https://reviews.llvm.org/D146991