[libcxx-commits] [PATCH] D146991: [libc++][NFC] Rename helper function for testing spaceship

Hristo Hristov via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 28 00:10:29 PDT 2023


H-G-Hristov added a comment.

@ldionne Thank you for pointing this out and fixing it. LGTM

Some of the tests are also misplaced and I have a patch to correct that https://reviews.llvm.org/D146902. I suppose I need to wait for you to commit these changes, so I can rebase and commit my fix to avoid conflicts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146991/new/

https://reviews.llvm.org/D146991



More information about the libcxx-commits mailing list