[libcxx-commits] [PATCH] D146359: [libc++] Use named Lit features to flag back-deployment XFAILs

[Louis Dionne via Phabricator via libcxx-commits]

ldionne marked an inline comment as done.
ldionne added inline comments.


================
Comment at: libcxx/utils/libcxx/test/features.py:357
+  # Tests that require std::filesystem support in the built library
+  Feature(name='availability-filesystem-missing',
+    when=lambda cfg: BooleanExpression.evaluate('use_system_cxx_lib && target={{.+}}-apple-macosx10.{{9|10|11|12|13|14}}', cfg.available_features)),
----------------
Mordante wrote:
> Since vendors can disable filesystem, can't you tie into the same feature?
Yeah, that was on my mind too, but for this patch I wanted to really just capture the availability failures. The `has-no-filesystem` feature is a bit different in intent -- it says whether the vendor has enabled the `filesystem` library, which is a bit different.

So basically, yes I want to reconsider this part of the filesystem enablement, but I think this approach is right for the scope of this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146359/new/

https://reviews.llvm.org/D146359