[libcxx-commits] [PATCH] D146359: [libc++] Use named Lit features to flag back-deployment XFAILs

[Mark de Wever via Phabricator via libcxx-commits]

Mordante accepted this revision.
Mordante added a comment.

I spot checked the patch, but trust on the CI to catch issues.

There's one question, other than that LGTM.



================
Comment at: libcxx/utils/libcxx/test/features.py:357
+  # Tests that require std::filesystem support in the built library
+  Feature(name='availability-filesystem-missing',
+    when=lambda cfg: BooleanExpression.evaluate('use_system_cxx_lib && target={{.+}}-apple-macosx10.{{9|10|11|12|13|14}}', cfg.available_features)),
----------------
Since vendors can disable filesystem, can't you tie into the same feature?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146359/new/

https://reviews.llvm.org/D146359