[libcxx-commits] [PATCH] D144994: [Draft][libc++][modules] Adds std module.

[Aaron Siddhartha Mondal via Phabricator via libcxx-commits]

aaronmondal added inline comments.


================
Comment at: libcxx/docs/Modules.rst:136
+The modules will shipped in a directory structure similar to the include.
+Includes are stored in ``<PREFIX>/modules/c++/v1`` modules will be stored in
+``<PREFIX>/modules/c++/v1/``.
----------------
tschuett wrote:
> I believe this is confusing. I thought that you want to store everything underneath `c++`? Additionally you use the same path  for includes and modules.
Typo? Should probably be "Includes are stored in `<prefix>/include/c++/v1`, modules in `<prefix>/modules/c++/v1`".

I think this makes sense. Modules can't be `#include`d anyways so there is a need for them to live in an `include/` directory. And for those using a different ABIs this leaves the possibility to have
```
.../include/c++/v1
.../include/c++/v2
.../modules/c++/v1
.../modules/c++/v2
```
or similar to clearly differentiate the headers/module interfaces.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144994/new/

https://reviews.llvm.org/D144994