[libcxx-commits] [PATCH] D144994: [Draft][libc++][modules] Adds std module.

[Thorsten via Phabricator via libcxx-commits]

tschuett added inline comments.


================
Comment at: libcxx/docs/Modules.rst:104
+   features become available.) Does libc++ want to retroactively supply the
+   module in ``C++23`` or restrict it to ``C++23`` and later?
+ * Do we want the feature behind a configuration flag or not? Louis already
----------------
C++20


================
Comment at: libcxx/docs/Modules.rst:136
+The modules will shipped in a directory structure similar to the include.
+Includes are stored in ``<PREFIX>/modules/c++/v1`` modules will be stored in
+``<PREFIX>/modules/c++/v1/``.
----------------
I believe this is confusing. I thought that you want to store everything underneath `c++`? Additionally you use the same path  for includes and modules.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144994/new/

https://reviews.llvm.org/D144994