[libcxx-commits] [PATCH] D144325: [NFC][libc++][format] Improves diagnostics.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/__format/format_arg_store.h:151-155
+// The overload for not formattable types.
+//
+// Originially this overload was marked as deleted, this resulted in 11 error
+// messages when a non-formattable type was used. Returning the "invalid type"
+// value, reduces this to 1 error message.
----------------
ldionne wrote:
> IMO this comment is not necessary in its current form, this is a job for the commit message instead.
I generally like to leave this kind of comments to indicate the current way is a conscious design decision. I usually only look at commit messages after encountering a bug/issue. I feel the commit message can be more verbose than the comments in the code.

In this case I don't feel too strongly since changing it will cause CI failures after D144326 lands. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144325/new/

https://reviews.llvm.org/D144325