[libcxx-commits] [PATCH] D144325: [NFC][libc++][format] Improves diagnostics.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

That's a really nice catch! Could we perhaps add a libc++ specific `.verify.cpp` test to lock in this behavior?



================
Comment at: libcxx/include/__format/format_arg_store.h:151-155
+// The overload for not formattable types.
+//
+// Originially this overload was marked as deleted, this resulted in 11 error
+// messages when a non-formattable type was used. Returning the "invalid type"
+// value, reduces this to 1 error message.
----------------
IMO this comment is not necessary in its current form, this is a job for the commit message instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144325/new/

https://reviews.llvm.org/D144325